-
Notifications
You must be signed in to change notification settings - Fork 27
ImageTransformations v0.9.0 #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
- Coverage 91.09% 89.06% -2.04%
==========================================
Files 8 8
Lines 191 192 +1
==========================================
- Hits 174 171 -3
- Misses 17 21 +4
Continue to review full report at Codecov.
|
timholy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! You've done absolutely heroic work here. Merge at will.
CHANGELOG.md
Outdated
| - ![Enhancement][badge-enhancement] `restrict` now works on 0-argument colorant types(e.g., `ARGB32`). ([ImageBase#3][github-base-3]) | ||
| - ![Bugfix][badge-bugfix] Interpolations v0.13.3 compatibility. ([#132][github-132]) | ||
| - ![Bugfix][badge-bugfix] `restrict` on singleton dimension is now a no-op. ([ImageBase#8][github-base-8]) | ||
| - ![Bugfix][badge-bugfix] `restrict` on `OffsetArray` is now type stable. ([ImageBase#4][github-base-4]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - ![Bugfix][badge-bugfix] `restrict` on `OffsetArray` is now type stable. ([ImageBase#4][github-base-4]) | |
| - ![Bugfix][badge-bugfix] `restrict` on `OffsetArray` always returns an `OffsetArray` result. ([ImageBase#4][github-base-4]) |
The meaning of "type-stable" is a little bit ambiguous: sometimes it means "the same type," but more often it simply means inferrable. Because of the potential for confusion, I think it's best to be specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I did mean inferrable here (#118) but it's almost the same 😄
Here's my plan for the next minor release:
Todo:
restrictnot preserving image colortype #68 (close or fix it)invwarpedviewin favor ofInvWarpedView(deprecateinvwarpedviewin favor ofInvWarpedView#138)summarytest in favor ofeltype/typeof/size/axes... (remove all summary test #136)imresize,zoomandimrotate#142)bugs:
maintenance:
enhancements:
imresize/imrotatefixed point (imresize/imrotatefixed point #121)The test failure is due to version locks on test dependency, no need to worry about.